Custom serializer register #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
============================================
- Coverage 71.95% 71.95% -0.01%
+ Complexity 784 783 -1
============================================
Files 415 416 +1
Lines 17654 17659 +5
Branches 2752 2752
============================================
+ Hits 12703 12706 +3
Misses 3549 3549
- Partials 1402 1404 +2
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lo1nt
force-pushed
the
dev_serializer_register
branch
from
277eee9 to
a093a33
Compare
OrezzerO
reviewed
Mar 3, 2023
...remoting-bolt/src/main/java/com/alipay/sofa/rpc/codec/bolt/SofaRpcSerializationRegister.java
Outdated
Show resolved
Hide resolved
...remoting-bolt/src/main/java/com/alipay/sofa/rpc/codec/bolt/SofaRpcSerializationRegister.java
Outdated
Show resolved
Hide resolved
| @@ -69,7 +72,10 @@ public class BoltServerProcessor extends AsyncUserProcessor<SofaRequest> { | |||
| * 提前注册序列化器 | |||
| */ | |||
| static { | |||
| SofaRpcSerializationRegister.registerCustomSerializer(); | |||
| String extensionAlias = RpcConfigs.getOrDefaultValue(RpcOptions.BOLT_SERIALIZER_REGISTER_EXTENSION, | |||
There was a problem hiding this comment.
If these static code can remove into constructor?
There was a problem hiding this comment.
It is designed here as:
- To do the register at same time as before.
- Get config and load extension once.
- Clarify it as ACTION belong to the
BoltServerProcessorclass, not only to a single BoltServerProcessor instance.
...rces/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.bolt.AbstractSerializationRegister
Outdated
Show resolved
Hide resolved
...ng/remoting-bolt/src/test/java/com/alipay/sofa/rpc/codec/bolt/BoltSerializationInitTest.java
Outdated
Show resolved
Hide resolved
...est/resources/META-INF/services/com.alipay.sofa.rpc.codec.bolt.AbstractSerializationRegister
Outdated
Show resolved
Hide resolved
...g/remoting-bolt/src/test/java/com/alipay/sofa/rpc/test/TestSofaRpcSerializationRegister.java
Outdated
Show resolved
Hide resolved
EvenLjj
reviewed
Apr 10, 2023
...ng/remoting-bolt/src/test/java/com/alipay/sofa/rpc/codec/bolt/BoltSerializationInitTest.java
Outdated
Show resolved
Hide resolved
Lo1nt
added a commit
that referenced
this pull request
Jun 20, 2023
* Modify the parsing header method to facilitate expansion (#1325) Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * feat: let use of javassist compatible at jdk 17 (#1316) Co-authored-by: junyuan <zhangminglun.zml@ant-group.com> * upgrade rpc version to 5.10.0-SNAPSHOT (#1326) * upgrade rpc version to 5.10.0-SNAPSHOT * upgrade rpc version to 5.10.0-SNAPSHOT --------- Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * Custom serializer register (#1296) * feat: use extension on serializer register --------- Co-authored-by: 均源 <zhangminglun.zml@antgroup.com> Co-authored-by: junyuan <zhangminglun.zml@ant-group.com> * chore: update version to release (#1328) Co-authored-by: lo1nt <zhangminglun.zml@ant-group.com> * upgrade rpc version to 5.10.1-SNAPSHOT (#1334) Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * support change grpc maxInboundMessageSize (#1333) Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * Fix the unit test message too large problem (#1339) * support change grpc maxInboundMessageSize * fix the debug body message too large problem --------- Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> * feat: bump hessian from 3.13.3 to 3.4.0 (#1338) Co-authored-by: Lo1nt <zhangminglun.zml@antgroup.com> * updapte 5.10.1 version to release (#1337) Co-authored-by: Lo1nt <zhangminglun.zml@antgroup.com> * update version * bump hessian * update version * add ci * set verison as 51100 * fix: destory * fix: unit test --------- Co-authored-by: evenliu <evenljj@163.com> Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com> Co-authored-by: lo1nt <zhangminglun.zml@ant-group.com> Co-authored-by: lo1nt <zhangminglun.zml@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, the custom serializer is registered by static code block. And once it registered, it could not be modified.
When there are several classes that register custom serializer, the sequence, dependents on sequence of class loading, is unpredictable, and unmodifiable.
Thus, there's no way we define our own serializer (say, for SofaRequest.Class).
The pr here is aiming at making custom serializer registration sequentially.
P.S. And we here still don't want to change the unmodifiable feature (Once a serializer registered, it can never be changed).
Modification:
Apply extension-loader mechanism to let the register work in sequence.
Still, there is an override feature for extension loader, which enables us to substitute the origin register provided by sofa rpc.
Result: