Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getDeserializerForCustomThrowable performance #1288

Merged
merged 5 commits into from
Jan 3, 2023

Conversation

rickey17
Copy link
Collaborator

Motivation:
Class.forName存在性能问题
spring-projects/spring-framework#18631

Modification:
增加缓存

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/L labels Dec 27, 2022
Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #1288 (8d35559) into master (1e386ed) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1288      +/-   ##
============================================
- Coverage     72.01%   71.98%   -0.04%     
  Complexity      783      783              
============================================
  Files           414      414              
  Lines         17565    17567       +2     
  Branches       2740     2740              
============================================
- Hits          12650    12645       -5     
- Misses         3521     3529       +8     
+ Partials       1394     1393       -1     
Impacted Files Coverage Δ
...nericMultipleClassLoaderSofaSerializerFactory.java 100.00% <100.00%> (ø)
...GenericSingleClassLoaderSofaSerializerFactory.java 89.65% <100.00%> (+0.36%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) ⬇️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 88.88% <0.00%> (-1.24%) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 71.54% <0.00%> (+0.26%) ⬆️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.01% <0.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj added this to the 5.9.1 milestone Jan 3, 2023
@EvenLjj EvenLjj merged commit 8b6b7c7 into sofastack:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants