Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom thread pool #855

Merged
merged 31 commits into from
Jul 14, 2022
Merged

custom thread pool #855

merged 31 commits into from
Jul 14, 2022

Conversation

shihuili1218
Copy link
Collaborator

custom thread pool, todo: DefaultFixedThreadsExecutorGroupFactory.toString

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@shihuili1218 shihuili1218 mentioned this pull request Jun 24, 2022
Closed
@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Jun 24, 2022
@sofastack-bot sofastack-bot bot added size/XXL and removed size/L labels Jun 24, 2022
@shihuili1218
Copy link
Collaborator Author

this is the implementation of issue #853

@shihuili1218
Copy link
Collaborator Author

Main changes: ThreadPool are all passed in through Options. The ThreadPool that sends AppendEntries messages is saved in DefaultRaftClientService; The ThreadPool for processing tasks is saved in the Map of the ThreadPoolGroup and obtained with the groupid.

killme2008
killme2008 reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution, but i found some problems. Feel free to discuss with us.

And i hope you can rebase the commit history, we hope the commit log clean and meanful.

jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolGroup.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/JRaftUtils.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/closure/ClosureQueueImpl.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/option/BootstrapOptions.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/option/NodeOptions.java Outdated Show resolved Hide resolved
tynan.liu and others added 3 commits June 28, 2022 16:58
fengjiachun
fengjiachun reviewed Jun 30, 2022
View reviewed changes
jraft-core/src/main/java/com/alipay/sofa/jraft/closure/ClosureQueueImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/FSMCallerImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/FSMCallerImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/impl/RocksDBLogStorage.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/snapshot/local/LocalSnapshotCopier.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/Utils.java Outdated Show resolved Hide resolved
killme2008
killme2008 reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great and amost done, but i have some comments above, please checking them and discuss with me if you have problems. Thank you for your great work. @farawayliu

jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/option/NodeOptions.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/ThreadPoolsFactory.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/util/Utils.java Show resolved Hide resolved
@shihuili1218 shihuili1218 changed the title custom thread pool, todo: DefaultFixedThreadsExecutorGroupFactory.toS… custom thread pool Jul 8, 2022
@sofastack-bot sofastack-bot bot added size/XL and removed size/XXL labels Jul 11, 2022
fengjiachun
fengjiachun approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit cebea9c into sofastack:master Jul 14, 2022
@fengjiachun fengjiachun mentioned this pull request Dec 13, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
cla:yes size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shihuili1218 @killme2008 @fengjiachun