Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) key not deleted in truncatePrefix #806

Merged
merged 1 commit into from
Mar 30, 2022
Merged

(fix) key not deleted in truncatePrefix #806

merged 1 commit into from
Mar 30, 2022

Conversation

killme2008
Copy link
Contributor

Motivation:

deleteFilesInRange in truncatePrefix is not enough, we have to call deleteRange too.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/M labels Mar 29, 2022
@killme2008 killme2008 requested a review from fengjiachun March 30, 2022 01:36
@killme2008 killme2008 force-pushed the feature/fix-truncate-prefix branch from 76c5cc3 to a8eed44 Compare March 30, 2022 03:44
fengjiachun
fengjiachun approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengjiachun fengjiachun merged commit 274e6d9 into master Mar 30, 2022
@fengjiachun fengjiachun deleted the feature/fix-truncate-prefix branch March 30, 2022 05:52
@fengjiachun fengjiachun mentioned this pull request Mar 30, 2022
Merged
@fengjiachun fengjiachun mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killme2008 @fengjiachun