Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Adds sliceData and getReadOnlyData methods to LogEntry, #755 #762

Merged
merged 1 commit into from
Feb 15, 2022
Merged

(feat) Adds sliceData and getReadOnlyData methods to LogEntry, #755 #762

merged 1 commit into from
Feb 15, 2022

Conversation

killme2008
Copy link
Contributor

Fix #755

@fengjiachun
Copy link
Contributor

是否可以增加一个 getBytes() ? @killme2008

@killme2008
Copy link
Contributor Author

@fengjiachun 感觉不需要啊，我们推荐用 byte buffer，用 byte buffer，你要怎么操作都行。

fengjiachun
fengjiachun approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengjiachun fengjiachun merged commit 75dad4b into master Feb 15, 2022
@fengjiachun fengjiachun deleted the feature/improve-log-data branch February 15, 2022 08:30
@fengjiachun fengjiachun mentioned this pull request Mar 17, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
cla:yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogEntry 中的 data 设计问题。
2 participants
@killme2008 @fengjiachun