(fix) use atomic move to avoid file corruption #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyang0423
changed the title
|
@yuyang0423 Please sign the CLA |
killme2008
approved these changes
Dec 20, 2021
|
LGTM |
Sorry, already signed, How can I trigger another build?? |
|
Hi @yuyang0423, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
@yuyang0423 你重新 sign 试下，显示还是没有 |
这下好像可以了，我们认为这个issue比较紧急，请确认一下如下情况，主要往archive插入 meta 前是sync 的， 插入meta之后因为修改过了， 并没有sync，之前的rename 把 |
|
@fengjiachun 可以看下，我觉的可以合并 |
|
Thank you @yuyang0423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
fix #604 , after few month test it's works fine.
RCA: temporary
kv.zipisn't sync to disk when finished appendmetain archive, should useatomic movethanrename