fix can't retry InstallSnapshot problem( #605 ) #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cked when a new InstallSnapshot request arrives, see #605
|
Hi @312223105, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
sofastack-bot
bot
added
bug
|
@312223105 你好，先执行一下 |
killme2008
reviewed
Jun 15, 2021
| } else if (m.request.getMeta().getLastIncludedIndex() > ds.request.getMeta().getLastIncludedIndex()) { | ||
| // |is| is older | ||
| // |ds| is older |
There was a problem hiding this comment.
This comment is error, the is is installing snapshot.
There was a problem hiding this comment.
Is line 625 also wrong? My understanding is that |xx| means xx is a variable. But there is no variable is in code.
There was a problem hiding this comment.
m is is, it was renamed someday before, but the comment was not changed.
horizonzy
pushed a commit
to horizonzy/sofa-jraft
that referenced
this pull request
Jun 25, 2021
* (fix) Fixed the problem that all InstallSnapshot sessions will be blocked when a new InstallSnapshot request arrives, see sofastack#605
horizonzy
pushed a commit
to horizonzy/sofa-jraft
that referenced
this pull request
Jun 25, 2021
* (fix) Fixed the problem that all InstallSnapshot sessions will be blocked when a new InstallSnapshot request arrives, see sofastack#605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixed the problem that all InstallSnapshot sessions will be blocked when a new InstallSnapshot request arrives, see #605
Result:
Fixes #605 .