Grpc max message size support config by user. #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
reviewed
Apr 1, 2021
| private final Map<Endpoint, ManagedChannel> managedChannelPool = new ConcurrentHashMap<>(); | ||
| private final Map<Endpoint, AtomicInteger> transientFailures = new ConcurrentHashMap<>(); | ||
| private static final int RPC_MAX_INBOUND_MESSAGE_SIZE = SystemPropertyUtil.getInt( | ||
| "grpc.max_inbound_message_size", |
There was a problem hiding this comment.
变量名建议加上 jraft 前缀，并且后面加上 bytes 单位 jraft.grpc.max_inbound_message_size.bytes
There was a problem hiding this comment.
似乎还是没加 jraft 前缀，并且存在重复代码，可以复用 rpc factory 的这个常量吧
There was a problem hiding this comment.
com.alipay.sofa.jraft.rpc.impl.GrpcRaftRpcFactory#RPC_SERVER_PROCESSOR_POOL_SIZE 这个字段的前缀没有jraft. 这里和RPC_SERVER_PROCESSOR_POOL_SIZE字段的前缀保持一致的。
可以用同一个key，让GrpcClient的复用GrpcRaftRpcFactory的。
There was a problem hiding this comment.
嗯，他原来没加也是不合适的，趁这次都加下 jraft 前缀，你可以一并改了，感谢
killme2008
reviewed
Apr 1, 2021
jraft-extension/rpc-grpc-impl/src/main/java/com/alipay/sofa/jraft/rpc/impl/GrpcClient.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.