Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code support property priority and docUrl #189

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

HzjNeverStop
Copy link
Contributor

@HzjNeverStop HzjNeverStop commented Aug 16, 2023

cherry-pick form (#187 )

2.error code support docUrl
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #189 (524d1eb) into master (ec43d9b) will increase coverage by 0.12%.
The diff coverage is 76.00%.

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
+ Coverage     34.49%   34.62%   +0.12%     
- Complexity      668      670       +2     
============================================
  Files            74       74              
  Lines          5673     5693      +20     
  Branches       1090     1094       +4     
============================================
+ Hits           1957     1971      +14     
- Misses         3466     3469       +3     
- Partials        250      253       +3     
Files Changed Coverage Δ
...ain/java/com/alipay/sofa/common/log/Constants.java 100.00% <ø> (ø)
...m/alipay/sofa/common/code/LogCode2Description.java 74.71% <76.00%> (-1.41%) ⬇️

Copy link

@taobaorun taobaorun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit e0ff800 into sofastack:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants