Test sync_labes #1

soehms · 2023-02-22T20:54:05Z

Is there an existing issue for this?

I have searched the existing issues for a bug report that matches the one I want to file, without success.

Did you read the documentation and troubleshoot guide?

I have read the documentation and troubleshoot guide

Environment

- **OS: Ubuntu 20.04**
- **Sage Version: 9.8**

Steps To Reproduce

No response

Expected Behavior

Labels of selection list should be unique.

Actual Behavior

You can select more than one label from a selection list.

Additional Information

No response

github-actions · 2023-02-22T21:21:08Z

Label s: needs work can not be added to an issue. Please use it on the corresponding PR

soehms · 2023-03-09T17:34:06Z

Starting tests for sync_labels

soehms · 2023-03-09T17:34:07Z

Test action opened

soehms · 2023-03-09T17:34:09Z

Test action reopened

soehms · 2023-03-09T17:34:11Z

Test action closed

soehms · 2023-03-09T17:34:12Z

Test action labeled

github-actions · 2023-03-09T17:34:29Z

Label s: positive review can not be added to an issue. Please use it on the corresponding PR

github-actions · 2023-03-09T17:34:30Z

Label s: needs work can not be added to an issue. Please use it on the corresponding PR

github-actions · 2023-03-09T17:34:33Z

Label s: needs review can not be added to an issue. Please use it on the corresponding PR

soehms · 2023-03-09T17:34:35Z

Test action unlabeled

soehms · 2023-03-09T17:34:38Z

Test action ready_for_review

github-actions · 2023-03-09T17:34:39Z

Label p: major /3 can not be added due to p: minor /4!

soehms · 2023-03-09T17:34:42Z

Test action synchronize

soehms · 2023-03-09T17:34:45Z

Test action review_requested

soehms · 2023-03-09T17:34:53Z

Test action converted_to_draft

soehms · 2023-03-09T17:34:54Z

Test action submitted

soehms · 2023-03-09T17:41:43Z

Almost all of the above comments and label changes have be created by the run_tests method of class GhLabelSynchronizer. Here are the log-messages of the run:

sage$ .github/sync_labels.py https://github.com/soehms/sage/issues/1 sagetrac-github-bot
INFO:root:cmdline_args (2) ['https://github.com/soehms/sage/issues/1', 'sagetrac-github-bot']
INFO:root:url: https://github.com/soehms/sage/issues/1
INFO:root:actor: sagetrac-github-bot
INFO:root:Create label handler for issue #1 and actor sagetrac-github-bot
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Starting tests for sync_labels"
https://github.com/soehms/sage/issues/1#issuecomment-1462475155
INFO:root:Add comment to issue #1: Starting tests for sync_labels
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action opened"
https://github.com/soehms/sage/issues/1#issuecomment-1462475184
INFO:root:Add comment to issue #1: Test action opened
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action reopened"
https://github.com/soehms/sage/issues/1#issuecomment-1462475215
INFO:root:Add comment to issue #1: Test action reopened
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action closed"
https://github.com/soehms/sage/issues/1#issuecomment-1462475245
INFO:root:Add comment to issue #1: Test action closed
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action labeled"
https://github.com/soehms/sage/issues/1#issuecomment-1462475275
INFO:root:Add comment to issue #1: Test action labeled
INFO:root:List of labels for issue #1: ['s: needs info']
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "s: positive review"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: s: positive review
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "s: needs work"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: s: needs work
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "s: needs review"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: s: needs review
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "p: blocker /1"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: p: blocker /1
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "p: critical /2"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: p: critical /2
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "p: major /3"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: p: major /3
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "p: minor /4"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: p: minor /4
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --add-label "p: trivial /5"
https://github.com/soehms/sage/issues/1
INFO:root:Add label to issue #1: p: trivial /5
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action unlabeled"
https://github.com/soehms/sage/issues/1#issuecomment-1462475756
INFO:root:Add comment to issue #1: Test action unlabeled
INFO:root:Execute command: gh issue edit https://github.com/soehms/sage/issues/1 --remove-label "s: needs info"
https://github.com/soehms/sage/issues/1
INFO:root:Remove label from issue #1: s: needs info
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action ready_for_review"
https://github.com/soehms/sage/issues/1#issuecomment-1462475829
INFO:root:Add comment to issue #1: Test action ready_for_review
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action synchronize"
https://github.com/soehms/sage/issues/1#issuecomment-1462475923
INFO:root:Add comment to issue #1: Test action synchronize
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action review_requested"
https://github.com/soehms/sage/issues/1#issuecomment-1462475990
INFO:root:Add comment to issue #1: Test action review_requested
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action converted_to_draft"
https://github.com/soehms/sage/issues/1#issuecomment-1462476130
INFO:root:Add comment to issue #1: Test action converted_to_draft
INFO:root:Execute command: gh issue comment https://github.com/soehms/sage/issues/1 -b "Test action submitted"
https://github.com/soehms/sage/issues/1#issuecomment-1462476164
INFO:root:Add comment to issue #1: Test action submitted

updated sage installation method with pip

this is a rebase over sagemath#34985

sort result of doctest to avoid random failures

### 📚 Description Trac branch `u/gh-collares/gap-gc` from sagemath#34701, now migrated to GitHub. Currently based atop sagemath#35093; will rebase once that is merged. The rest of the description below is copied from sagemath#34701: A refactor in sagemath#27946 introduced "unprotected" (not surrounded by `GAP_Enter`/`GAP_Leave`) `GAP_ValueGlobalVariable` calls. I believe this might be a GC hazard, because after updating to GAP 4.12.1 I started seeing aarch64 crashes on NixOS infrastructure such as: ``` #0 0x0000fffff79740e8 in wait4 () #1 0x0000fffff5dc6b78 in print_enhanced_backtrace () #2 0x0000fffff5dc8190 in sigdie () #3 0x0000fffff5dcb1c0 in cysigs_signal_handler () #4 0x0000fffff7ffb7cc in __kernel_rt_sigreturn () #5 0x0000ffff99a0bf28 in ConvString () #6 0x0000000000000000 in ?? () #7 0x0000000000000000 in ?? () #8 0x0000000000000000 in ?? () #9 0x0000ffff99989930 in Pr () #10 0x0000ffff9998aa18 in CloseOutput () #11 0x0000ffff99884828 in capture_stdout () at /build/sage- src-9.7/pkgs/sagemath-standard/sage/libs/gap/element.pyx:154 ... ``` I also see cases where `capture_stdout` throws errors such as `sage.libs.gap.util.GAPError: Error, Length: <list> must be a list (not the integer 255)` and then crashes. Both types of errors are fixed by this ticket. Note that I am nesting `GAP_Enter`/`GAP_Leave` calls because I didn't remove the preexisting calls inside `capture_stdout`. That's because I feared removing the innermost calls might create a new footgun (and I believe nested `GAP_Enter`/`GAP_Leave` calls are explicitly supported), but removing them should cause no problem. Removing them might even be preferable for performance reasons, I don't know. Fixes sagemath#34701 ### 📝 Checklist    - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   - sagemath#35093: GAP 4.12.2 upgrade, which touches the same function and should land first. URL: sagemath#35114 Reported by: Mauricio Collares Reviewer(s): Dima Pasechnik

move bliss_find_automorphisms.h to subdir

Gcc 13

added two doctests:

soehms · 2023-11-21T07:24:32Z

Thats'done

For C-return-type functions that raise exceptions (and their heirs).

soehms added s: needs review s: needs work labels Feb 22, 2023

github-actions bot removed the s: needs work label Feb 22, 2023

soehms added the s: needs info label Feb 22, 2023

github-actions bot removed the s: needs review label Feb 22, 2023

soehms added s: positive review s: needs work s: needs review p: blocker /1 p: critical /2 p: major /3 labels Mar 9, 2023

github-actions bot removed the s: positive review label Mar 9, 2023

soehms added the p: minor /4 label Mar 9, 2023

github-actions bot removed the s: needs work label Mar 9, 2023

soehms added the p: trivial /5 label Mar 9, 2023

github-actions bot removed s: needs review p: blocker /1 labels Mar 9, 2023

soehms removed the s: needs info label Mar 9, 2023

github-actions bot removed p: critical /2 p: major /3 labels Mar 9, 2023

github-actions bot removed p: minor /4 p: trivial /5 labels Mar 9, 2023

soehms mentioned this issue Mar 9, 2023

New workflow for synchronization of labels sagemath/sage#35172

Merged

4 tasks

soehms pushed a commit that referenced this issue Mar 13, 2023

Merge pull request #1 from zovelsanj/zovelsanj-patch-1

ec867ac

updated sage installation method with pip

soehms pushed a commit that referenced this issue Mar 13, 2023

Merge pull request #1 from dimpase/wwp

6db139e

this is a rebase over sagemath#34985

soehms pushed a commit that referenced this issue Mar 13, 2023

Merge pull request #1 from mantepse/bijectionist

a72bd65

sort result of doctest to avoid random failures

soehms pushed a commit that referenced this issue Jul 3, 2023

Merge pull request #1 from dimpase/bliss-0.77

c61f9ae

move bliss_find_automorphisms.h to subdir

soehms pushed a commit that referenced this issue Sep 8, 2023

Merge pull request #1 from mkoeppe/gcc_13

ce6d2dc

Gcc 13

soehms pushed a commit that referenced this issue Oct 9, 2023

Merge pull request #1 from brettpim/covering_array_two

5e23de2

added two doctests:

soehms closed this as completed Nov 21, 2023

soehms added s: needs work p: major /3 p: minor /4 and removed s: needs work labels Dec 15, 2023

github-actions bot removed the p: major /3 label Dec 15, 2023

soehms added the p: major /3 label Feb 3, 2024

github-actions bot removed the p: minor /4 label Feb 3, 2024

soehms pushed a commit that referenced this issue Sep 13, 2024

Add some excepts (#1)

31d6a6b

For C-return-type functions that raise exceptions (and their heirs).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test sync_labes #1

Test sync_labes #1

soehms commented Feb 22, 2023 •

edited

Loading

github-actions bot commented Feb 22, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Nov 21, 2023

Test sync_labes #1

Test sync_labes #1

Comments

soehms commented Feb 22, 2023 • edited Loading

Is there an existing issue for this?

Did you read the documentation and troubleshoot guide?

Environment

Steps To Reproduce

Expected Behavior

Actual Behavior

Additional Information

github-actions bot commented Feb 22, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Mar 9, 2023

soehms commented Nov 21, 2023

soehms commented Feb 22, 2023 •

edited

Loading