Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsp change volume's get rule #953

Merged
merged 2 commits into from
Dec 12, 2022
Merged

vsp change volume's get rule #953

merged 2 commits into from
Dec 12, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #953 (6ef9d9f) into master (4ba8e59) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage   71.35%   71.37%   +0.01%     
==========================================
  Files         187      187              
  Lines       23067    23071       +4     
  Branches     3508     3510       +2     
==========================================
+ Hits        16460    16466       +6     
+ Misses       5491     5490       -1     
+ Partials     1116     1115       -1     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/vsp_stor.py 68.85% <60.00%> (+0.29%) ⬆️
delfin/drivers/fake_storage/__init__.py 95.17% <0.00%> (+0.50%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit e8862a6 into sodafoundation:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants