Add ansible delfin installer #942

joseph-v · 2022-11-17T06:25:16Z

What this PR does / why we need it:
Add standalone ansible install for delfin

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

codecov · 2022-11-17T09:50:12Z

Codecov Report

Merging #942 (57c0d25) into master (9ad2996) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   71.36%   71.35%   -0.01%     
==========================================
  Files         187      187              
  Lines       23067    23067              
  Branches     3508     3508              
==========================================
- Hits        16462    16460       -2     
- Misses       5490     5491       +1     
- Partials     1115     1116       +1

Impacted Files	Coverage Δ
delfin/drivers/fake_storage/__init__.py	`94.67% <0.00%> (-0.51%)`	⬇️

PravinRanjan10

May be gelato related term we can remove.

skdwriting

Pls check the comments

skdwriting · 2022-11-24T08:10:18Z

installer/README.md

+
+The SODA Delfin supports two types of installation
+* Installation using Ansible for user experiance with Dashboard
+* Installation using scripts


using scripts? Or Installation with Dashboard and Installation with CLI?

Removed dashboard, srm_toolchain and auth install files. Updated banner and documentation.

skdwriting · 2022-11-24T08:13:03Z

installer/README.md

+
+
+
+## Bash installer


Can we use the installer names consistently in the beginning also? Or please say Installation option 1 : Ansible...and Installation option 2: Bash Script installer in the title. Also use consistently across the doc

skdwriting · 2022-11-24T08:20:36Z

installer/ansible/group_vars/auth.yml

@@ -0,0 +1,38 @@
+# Copyright 2019 The OpenSDS Authors.


SODA Authors

Why do we need all these files for single project installer also...(separate files in group_vars)

skdwriting · 2022-11-24T08:21:56Z

installer/ansible/group_vars/common.yml

@@ -0,0 +1,60 @@
+# Copyright 2019 The OpenSDS Authors.


SODA Authors (all occurrences, pls check)

skdwriting · 2022-11-24T08:25:19Z

installer/ansible/group_vars/srm-toolchain.yml

@@ -0,0 +1,46 @@
+# Copyright 2020 The SODA Authors.


Any reason for 2020 ? (For all occurrences)

skdwriting · 2022-11-24T08:27:58Z

installer/ansible/roles/dashboard-installer/scenarios/container.yml

+      OPENSDS_GELATO_URL: "http://{{ host_ip }}:8089"
+      SODA_DELFIN_URL: "{{ soda_delfin_url }}"
+      OPENSDS_ORCHESTRATION_URL: "http://{{ host_ip }}:5000"
+      OPENSDS_S3_URL: "http://{{ host_ip }}:8090"


All the env are needed for Delfin?!
Why should it be called OpenSDS or SODA ?
Any env variable at SODA level should be part of SODA installer / dashboard not delfin.
Delfin should handle delfin env vars

skdwriting · 2022-11-24T08:28:50Z

installer/ansible/roles/dashboard-installer/scenarios/source-code.yml

+- name: build and configure opensds dashboard
+  shell: "{{ item }}"
+  with_items:
+    - service apache2 stop


If we do this way, will it not affect the dashboard of any other existing instance of the dashboard?!

skdwriting · 2022-11-24T08:30:33Z

installer/ansible/script/create_cert.sh

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+openssl version >& /dev/null


needed for delfin?!

skdwriting · 2022-11-24T08:30:58Z

installer/ansible/script/keystone.sh

@@ -0,0 +1,279 @@
+#!/usr/bin/env bash
+


keystone for delfin?!

skdwriting · 2022-11-24T08:31:24Z

installer/ansible/script/ministone.py

+import json
+
+
+def token_issue():


needed for delfin?

skdwriting · 2022-11-25T04:18:20Z

installer/README.md


-# Supported OS
-Ubuntu 16.04, Ubuntu 18.04
+## Ansible installer


Installation using Ansible

skdwriting · 2022-11-25T04:19:01Z

installer/README.md

+
+
+
+## Bash script installer


Installation using Bash Scripts

skdwriting · 2022-11-25T04:53:03Z

installer/README.md

-```
-
-# Logs
+### Logs
 All the installer logs are stored in the /var/log/sodafoundation directory.


can we change the directory name from sodafoundation to soda?

skdwriting

LGTM

joseph-v force-pushed the ansible-installer branch 5 times, most recently from e7830b1 to ee4a41b Compare November 17, 2022 09:46

joseph-v force-pushed the ansible-installer branch 5 times, most recently from e296889 to b3f6dc8 Compare November 23, 2022 04:05

Add ansible delfin installer

aabda0f

joseph-v force-pushed the ansible-installer branch from b3f6dc8 to 216aae3 Compare November 23, 2022 06:28

sushanthakumar previously approved these changes Nov 23, 2022

View reviewed changes

PravinRanjan10 reviewed Nov 24, 2022

View reviewed changes

skdwriting reviewed Nov 24, 2022

View reviewed changes

Fixes for 20.04 and new docker compose

876915c

joseph-v dismissed sushanthakumar’s stale review via 876915c November 24, 2022 11:34

joseph-v force-pushed the ansible-installer branch 3 times, most recently from 72500f7 to 69c7f83 Compare November 25, 2022 03:32

Remove dashboard, keystone and srm toolchain

881db73

joseph-v force-pushed the ansible-installer branch from 69c7f83 to 881db73 Compare November 25, 2022 04:05

skdwriting reviewed Nov 25, 2022

View reviewed changes

Update for review comments

57c0d25

skdwriting approved these changes Nov 25, 2022

View reviewed changes

sushanthakumar approved these changes Nov 25, 2022

View reviewed changes

sushanthakumar merged commit aa40fcd into sodafoundation:master Nov 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ansible delfin installer #942

Add ansible delfin installer #942

joseph-v commented Nov 17, 2022

codecov bot commented Nov 17, 2022 •

edited

Loading

PravinRanjan10 left a comment

skdwriting left a comment

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 24, 2022

joseph-v Nov 24, 2022

skdwriting Nov 25, 2022

joseph-v Nov 25, 2022

skdwriting Nov 25, 2022

joseph-v Nov 25, 2022

skdwriting Nov 25, 2022

joseph-v Nov 25, 2022

skdwriting left a comment

		import json


		def token_issue():

Add ansible delfin installer #942

Add ansible delfin installer #942

Conversation

joseph-v commented Nov 17, 2022

codecov bot commented Nov 17, 2022 • edited Loading

Codecov Report

PravinRanjan10 left a comment

Choose a reason for hiding this comment

skdwriting left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skdwriting left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 17, 2022 •

edited

Loading