Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hpe 3par: change to lower case and add digital judgment #935

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

yuanyu-ghca
Copy link
Contributor

What this PR does / why we need it:
1 change to lower case
2 add digital judgment

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

yuanyu-ghca and others added 2 commits October 28, 2022 09:38
2.Add digital judgment
Change to lower case and add digital judgment
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #935 (e54f68c) into master (ddcdd27) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
+ Coverage   71.47%   71.51%   +0.04%     
==========================================
  Files         181      181              
  Lines       21925    21925              
  Branches     3333     3333              
==========================================
+ Hits        15671    15680       +9     
+ Misses       5182     5176       -6     
+ Partials     1072     1069       -3     
Impacted Files Coverage Δ
delfin/drivers/hpe/hpe_3par/component_handler.py 74.38% <0.00%> (ø)
delfin/drivers/fake_storage/__init__.py 95.17% <0.00%> (+2.28%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit f89d0b0 into sodafoundation:master Oct 28, 2022
@yuanyu-ghca yuanyu-ghca deleted the hpe_3par_20221028 branch October 28, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants