Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu usage metric of the controller #919

Merged

Conversation

JiuyunZhao
Copy link
Contributor

@JiuyunZhao JiuyunZhao commented Jul 26, 2022

What this PR does / why we need it:

  1. Add cpu usage metric of the controller.
  2. Delete unused code.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@JiuyunZhao JiuyunZhao changed the title Add cpu usage metric of controller. Add cpu usage metric of the controller Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #919 (0cc17b8) into master (6729541) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files         182      182           
  Lines       21931    21918   -13     
  Branches     3343     3343           
=======================================
- Hits        15607    15598    -9     
+ Misses       5268     5261    -7     
- Partials     1056     1059    +3     
Impacted Files Coverage Δ
delfin/api/schemas/storage_capabilities_schema.py 100.00% <ø> (ø)
delfin/drivers/fake_storage/__init__.py 94.41% <ø> (-1.02%) ⬇️
...dulers/telemetry/performance_collection_handler.py 90.27% <ø> (ø)
delfin/utils.py 28.61% <ø> (-0.42%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 2756fac into sodafoundation:master Jul 27, 2022
@JiuyunZhao JiuyunZhao deleted the jiuyunzhao_cpu_usage_20221030 branch June 8, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants