add ScaleIO storage Sofotware staorage\Volume\DIsk\Pool Info Collection #904
Conversation
add ScaleIO storage software data collection
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 71.16% 71.01% -0.16%
==========================================
Files 182 186 +4
Lines 21918 22286 +368
Branches 3343 3397 +54
==========================================
+ Hits 15598 15826 +228
- Misses 5261 5388 +127
- Partials 1059 1072 +13
|
add scaleio storage software data collection
update scaleio initiators descroption
| alert_model = { | ||
| 'alert_id': json_alert.get('id'), | ||
| 'alert_name': alert_type + json_alert.get('name'), | ||
| 'severity': json_alert.get('severity'), |
There was a problem hiding this comment.
Can the alarm severity obtained from the device be directly adapted to the alarm servity defined in the code? if not, pls handle the alarm.
There was a problem hiding this comment.
Added data for determining alarm levels.
| status = constants.HostStatus.NORMAL | ||
| elif 'Disconnected' == status: | ||
| status = constants.HostStatus.OFFLINE | ||
| initiators_dict = { |
There was a problem hiding this comment.
pls add the initiator type.
There was a problem hiding this comment.
Added the initiator type and modified the initiator status
| side_effect=[test_constans.SYSTEM_ALERT_INFO]) | ||
| storage_alert = ScaleioStorageDriver(**ACCESS_INFO).\ | ||
| list_alerts(context) | ||
| self.assertEqual(storage_alert, test_constans.SYSTEM_ALERT) |
There was a problem hiding this comment.
The alarm time is a random value, The constant value in the unit test may be different from the actual value. As a result, the test code reports an error.
There was a problem hiding this comment.
Modified the time in the test results，No problem was found with the time conversion in the method
The printed time data is：
Converts the millisecond value time：
| "name": view_name + sdc_id + volume_id, | ||
| "description": view_name, | ||
| "storage_id": storage_id, | ||
| "native_masking_view_id": str(uid) + volume_id, |
There was a problem hiding this comment.
native_masking_view_id should be a unique value, so the data generated in this way is different.
There was a problem hiding this comment.
Replace the random ID with name plus host ID plus volume ID
add trap alert and alert info update
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: