Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vplex masking_view id #824

Merged
merged 8 commits into from
May 19, 2022
Merged

Conversation

luojiagen
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #824 (277855a) into master (59475e2) will increase coverage by 0.02%.
The diff coverage is 77.35%.

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage   71.32%   71.35%   +0.02%     
==========================================
  Files         182      182              
  Lines       20823    20929     +106     
  Branches     3177     3194      +17     
==========================================
+ Hits        14853    14934      +81     
- Misses       4966     4984      +18     
- Partials     1004     1011       +7     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/vplex/rest_handler.py 48.64% <25.00%> (-1.84%) ⬇️
delfin/drivers/dell_emc/vplex/vplex_stor.py 80.24% <81.25%> (+0.24%) ⬆️
delfin/drivers/dell_emc/vplex/consts.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 94.40% <0.00%> (-0.26%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 32769d1 into sodafoundation:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants