ds8000 add host mapping #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 70.59% 70.59%
=======================================
Files 180 181 +1
Lines 18825 18880 +55
Branches 2769 2777 +8
=======================================
+ Hits 13289 13329 +40
- Misses 4694 4706 +12
- Partials 842 845 +3
|
delfin/drivers/ibm/ds8k/ds8k.py
Outdated
| def list_storage_hosts(self, context): | ||
| try: | ||
| host_list = [] | ||
| hosts = self.rest_handler.get_rest_info('/api/v1/hosts') |
There was a problem hiding this comment.
It is recommended that the URL path be maintained in constants.
wisererik
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: