Add hostmapping support to VMAX driver #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 70.56% 70.58% +0.01%
==========================================
Files 180 180
Lines 18654 18825 +171
Branches 2750 2769 +19
==========================================
+ Hits 13164 13288 +124
- Misses 4646 4694 +48
+ Partials 844 843 -1
|
joseph-v
force-pushed
the
vmax-hostmapping-update
branch
3 times, most recently
from
3a14aab
to
aa8faaa
Compare
| port_group_list.append(port_group_item) | ||
|
|
||
| for port in port_group_info['symmetrixPortKey']: | ||
| port_name = port['directorId'] + ':' + port['portId'] |
There was a problem hiding this comment.
Just portId is not unique, can it be not treated as native_port_id?
There was a problem hiding this comment.
Just portId is not unique, can it be not treated as native_port_id?
Yes, portId is not unique, so we generate directorId + portId for native_port_id
joseph-v
force-pushed
the
vmax-hostmapping-update
branch
from
aa8faaa
to
945e9b6
Compare
|
LGTM |
joseph-v
force-pushed
the
vmax-hostmapping-update
branch
from
945e9b6
to
635ff15
Compare
joseph-v
force-pushed
the
vmax-hostmapping-update
branch
from
635ff15
to
a21d1fe
Compare
joseph-v
force-pushed
the
vmax-hostmapping-update
branch
2 times, most recently
from
fc61aa0
to
28ba103
Compare
|
LGTM |
joseph-v
force-pushed
the
vmax-hostmapping-update
branch
from
d9f6934
to
92b31fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add hostmapping support to VMAX driver
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #654Special notes for your reviewer:
Release note: