Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NetApp mapping view interface #797

Merged
merged 27 commits into from
May 18, 2022
Merged

Conversation

guankc
Copy link
Contributor

@guankc guankc commented Jan 11, 2022

The NetApp add interface:

'list_storage_host_initiators',
'list_port_groups',
'list_storage_hosts',
'list_masking_views'

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #797 (fef3561) into master (b92804f) will increase coverage by 0.05%.
The diff coverage is 77.43%.

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   70.72%   70.77%   +0.05%     
==========================================
  Files         181      182       +1     
  Lines       20104    20297     +193     
  Branches     3037     3073      +36     
==========================================
+ Hits        14218    14366     +148     
- Misses       4913     4951      +38     
- Partials      973      980       +7     
Impacted Files Coverage Δ
delfin/drivers/netapp/dataontap/netapp_handler.py 64.10% <44.82%> (-1.52%) ⬇️
delfin/drivers/netapp/dataontap/mapping_handler.py 89.74% <89.74%> (ø)
delfin/drivers/netapp/dataontap/cluster_mode.py 95.08% <100.00%> (+0.74%) ⬆️
delfin/drivers/netapp/dataontap/constants.py 100.00% <100.00%> (ø)
delfin/drivers/utils/tools.py 64.65% <100.00%> (-4.32%) ⬇️
delfin/drivers/fake_storage/__init__.py 94.65% <0.00%> (+1.01%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 21afd81 into sodafoundation:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants