Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ibm ds8000 system pool volume alerts resources #790

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:
add ibm ds8000 system pool volume alerts resources

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #790 (8bd579f) into master (a9c31b5) will decrease coverage by 0.00%.
The diff coverage is 69.79%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   70.56%   70.55%   -0.01%     
==========================================
  Files         174      177       +3     
  Lines       17998    18243     +245     
  Branches     2648     2688      +40     
==========================================
+ Hits        12700    12872     +172     
- Misses       4507     4558      +51     
- Partials      791      813      +22     
Impacted Files Coverage Δ
delfin/drivers/ibm/ds8k/rest_handler.py 50.74% <50.74%> (ø)
delfin/drivers/ibm/ds8k/ds8k.py 76.38% <76.38%> (ø)
delfin/drivers/ibm/ds8k/alert_handler.py 79.41% <79.41%> (ø)
delfin/drivers/fake_storage/__init__.py 95.34% <0.00%> (+0.27%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 73c98e4 into sodafoundation:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants