Hpe 3par add collect performance interface #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add collect performance interface
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
+ Coverage 70.77% 70.80% +0.02%
==========================================
Files 181 181
Lines 19547 19865 +318
Branches 2921 2981 +60
==========================================
+ Hits 13834 14065 +231
- Misses 4797 4855 +58
- Partials 916 945 +29
|
Add collect performance interface
JiuyunZhao
reviewed
Jan 21, 2022
| @@ -103,6 +108,11 @@ def get_resinfo_call(self, url, data=None, method=None): | |||
| if res is not None: | |||
| if res.status_code == consts.SUCCESS_STATUS_CODES: | |||
| rejson = res.json() | |||
| else: | |||
| if res.text and 'unsupported' in res.text: | |||
| LOG.warn('rest api error: {}'.format(res.text)) | |||
There was a problem hiding this comment.
Please use warning insteand.
Merge branch 'master'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add collect performance interface
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note: