Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vmax disk metrics #777

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Conversation

joseph-v
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@joseph-v joseph-v force-pushed the vmax_disk_metrics branch 2 times, most recently from 6908f80 to f50158c Compare December 2, 2021 04:43
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #777 (43a7aeb) into master (7df3406) will decrease coverage by 0.11%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
- Coverage   70.33%   70.21%   -0.12%     
==========================================
  Files         163      163              
  Lines       15877    15910      +33     
  Branches     2265     2272       +7     
==========================================
+ Hits        11167    11172       +5     
- Misses       4034     4063      +29     
+ Partials      676      675       -1     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/vmax/vmax.py 79.16% <0.00%> (-3.45%) ⬇️
delfin/drivers/dell_emc/vmax/client.py 72.72% <9.09%> (-2.75%) ⬇️
delfin/drivers/dell_emc/vmax/rest.py 44.59% <10.52%> (-1.21%) ⬇️
delfin/drivers/dell_emc/vmax/constants.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 95.61% <0.00%> (+0.54%) ⬆️

@joseph-v joseph-v changed the title WIP: Vmax disk metrics Vmax disk metrics Dec 2, 2021
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit b4ae445 into sodafoundation:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants