Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed task scheduling based on driver capability #763

Merged

Conversation

sushanthakumar
Copy link
Collaborator

What this PR does / why we need it:
This PR addresses the failed task scheduling mechanism considering the driver capability about performance metric retention window.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This PR addresses the issue #757

Special notes for your reviewer:
Test scenarios verified here are:

Driver supports performance_metric_retention_window which is less than delfin max collection window
Driver supports performance_metric_retention_window which is more than delfin max collection window
Driver does not support performance_metric_retention_window -> use default interval
Driver throws exception for get_driver_capabilites

Release note:

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #763 (4ff906c) into master (b8de7c6) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   70.42%   70.41%   -0.01%     
==========================================
  Files         163      163              
  Lines       15836    15850      +14     
  Branches     1960     1961       +1     
==========================================
+ Hits        11152    11161       +9     
- Misses       4010     4014       +4     
- Partials      674      675       +1     
Impacted Files Coverage Δ
delfin/api/schemas/storage_capabilities_schema.py 100.00% <ø> (ø)
delfin/common/config.py 95.00% <ø> (ø)
delfin/drivers/fake_storage/__init__.py 95.06% <ø> (ø)
...dulers/telemetry/performance_collection_handler.py 92.64% <64.28%> (-7.36%) ⬇️
delfin/common/constants.py 100.00% <100.00%> (ø)

@sushanthakumar
Copy link
Collaborator Author

@NajmudheenCT @joseph-v @ThisIsClark pls help to review this

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisIsClark ThisIsClark merged commit 116a391 into sodafoundation:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants