Adding overlap between collection intervals #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
==========================================
- Coverage 70.42% 70.42% -0.01%
==========================================
Files 163 163
Lines 15850 15853 +3
Branches 1961 1961
==========================================
+ Hits 11162 11164 +2
Misses 4014 4014
- Partials 674 675 +1
|
|
LGTM |
NajmudheenCT
dismissed stale reviews from ThisIsClark and joseph-v
via
6db3d25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If Delfin and storage device/ device manager has different time set, the metric collection would miss some time stamp in below scenarios
-Delfin node time is ahead of the actual time
-Storage device/ device manager is behind actual time
-Both sample generation and delfin collection trigger has a coincidence
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #759Special notes for your reviewer:
Release note: