Example Add the WWN information for netApp luns #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example Add the WWN information for netApp luns
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 70.55% 70.56% +0.01%
==========================================
Files 177 177
Lines 18243 18244 +1
Branches 2688 2688
==========================================
+ Hits 12871 12874 +3
Misses 4558 4558
+ Partials 814 812 -2
|
Example Add the WWN information for netApp luns
| @@ -41,6 +41,7 @@ class NetAppHandler(object): | |||
| OID_TRAP_DATA = '1.3.6.1.4.1.789.1.1.12.0' | |||
| NODE_NAME = 'controller_name' | |||
| SECONDS_TO_MS = 1000 | |||
| NETAPP_WWN = '60a98000' | |||
There was a problem hiding this comment.
recommended variable name: NETAPP_NAA
wisererik
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Add the WWN information for netApp luns
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: