Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the eth port name #731

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Conversation

guankc
Copy link
Contributor

@guankc guankc commented Sep 28, 2021

Modify the eth port name

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #731 (ad8bbff) into master (73c98e4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   70.54%   70.55%           
=======================================
  Files         177      177           
  Lines       18243    18243           
  Branches     2688     2688           
=======================================
+ Hits        12870    12871    +1     
  Misses       4558     4558           
+ Partials      815      814    -1     
Impacted Files Coverage Δ
delfin/drivers/netapp/dataontap/netapp_handler.py 66.10% <ø> (ø)
delfin/drivers/fake_storage/__init__.py 95.06% <0.00%> (+0.27%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit e961cef into sodafoundation:master Jan 5, 2022
@guankc guankc deleted the netapp_port branch February 9, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants