unity fix the issue which when filesystem is None in get_share #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the issue which when filesystem is None in get_share
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 70.22% 70.41% +0.19%
==========================================
Files 163 163
Lines 15627 15836 +209
Branches 1939 1960 +21
==========================================
+ Hits 10974 11151 +177
- Misses 3992 4010 +18
- Partials 661 675 +14
|
fix some compatibility issue
tanjiangyu-ghca
changed the title
do some optimize
change fcport connect_status
change fcport localtion
JiuyunZhao
reviewed
Sep 28, 2021
| @@ -81,44 +83,47 @@ def login(self): | |||
| LOG.error("Login error: %s", six.text_type(e)) | |||
| raise e | |||
|
|
|||
| def call_with_token(self, url, data, method): | |||
| def call_with_token(self, url, data, method, calltimeout): | |||
There was a problem hiding this comment.
data can set default ot None, method default to GET, calltimeout default to consts.DEFAULT_TIMEOUT.
| self.call(RestHandler.REST_LOGOUT_URL, method='POST') | ||
| self.call(RestHandler.REST_LOGOUT_URL, | ||
| consts.DEFAULT_TIMEOUT, | ||
| data={}, method='POST') |
There was a problem hiding this comment.
parameter data can use default value of method call().
| if res.status_code == 200: | ||
| result_json = res.json() | ||
| return result_json | ||
|
|
||
| def call(self, url, data=None, method=None): | ||
| def call(self, url, calltimeout, data=None, method=None): |
There was a problem hiding this comment.
Since the parameters of call() is the same as the parameters of call_with_token(), these parameters should be in the same order.
| 'messageId,message,description,' | ||
| 'descriptionId', | ||
| page_number) | ||
| result_json = self.get_rest_info(url, consts.ALERT_TIMEOUT) |
There was a problem hiding this comment.
The second parameter of get_rest_info() is data, not calltimeout.
| auth_key = None | ||
| if self.session: | ||
| auth_key = self.session.headers.get(RestHandler.AUTH_KEY, None) | ||
| if auth_key: | ||
| self.session.headers[RestHandler.AUTH_KEY] \ | ||
| = cryptor.decode(auth_key) | ||
| res = self.do_call(url, data, method) | ||
| res = self.do_call(url, data, method, calltimeout) |
There was a problem hiding this comment.
The default value of parameter calltimeout in do_call() is from driver code of HPE 3par, method do_call() is a common method, I think its default value should be also from common module or from its own.
…into unity_0916
remove the disk when it's slot is empty
change disk physicaltype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1.fix the issue which when filesystem is None in get
2.fix some compatibility issue
3.change fcport localtion and connect_status
4.change get alarm's timeout
5.change port speed and disk name
6.remove the disk when it's slot is empty
7.change disk physicaltype
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: