Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison row count check secondary datasource filter fix #2165

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

asantoz
Copy link
Contributor

@asantoz asantoz commented Sep 18, 2024

Description

This PR fix the bug on RowCountComparisonCheck in case of a secondary table datasource with filter compare, the current bug ignores the partition_sql filter.

Changes

  • Fix partition creation on RowCountComparisonCheck adding the partition config

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

@asantoz asantoz force-pushed the CLOUD-8268-fix-partition-filter-sql branch from beaaa86 to 11d3d23 Compare September 18, 2024 13:52
@asantoz asantoz force-pushed the CLOUD-8268-fix-partition-filter-sql branch from ba71e97 to 425ee8d Compare October 14, 2024 18:33
Copy link
Contributor

@m1n0 m1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this LGTM, merging!

Copy link

@m1n0 m1n0 merged commit b91b1a9 into sodadata:main Oct 22, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants