Add support for Azure SQL, Synapse, and Microsoft Fabric and extend support for SQL Server #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
for more information, see https://pre-commit.ci
This was referenced Sep 10, 2024
Closed
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
m1n0
approved these changes
Oct 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Microsoft Fabric Lakehouses and Data Warehouses as a data source and along with it extends support for the existing SQL Server data source.
What this PR does/includes:
Extend authentication methods for SQL Server
This should make a lot of T-SQL users happy. I am also one of the lead maintainers for the dbt adapters which do the same thing. So basically I added the features which the dbt adapters support to this data source as well.
The data source now supports all the common authentication methods users of SQL Server (on-prem), Azure SQL DB, and Azure SQL Server Managed Instance use. This has probably also opened the door to compatibility with Azure Synapse Dedicated SQL Pools (because of the data types they probably should use the dbt-fabric adapter).
Create a new Fabric data source as a child of the SQL Server data source
The Fabric data source is different from the one for SQL Server in which data types are allowed. Furthermore it inherits from SQL Server.
No failing tests :)
Fabric T-SQL surface area is a bit smaller than the one in SQL Server. SQL Server was skipped on a lot of tests and this will unfortunately be the same for Fabric at this moment.
I'd be happy to work with you to add this to your CI but then we'd need to work together through Slack to configure the cloud infrastructure.