Allow custom session ids #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about having a single option |
|
Thank you for your prompt reply.
Let me clear this question before I change the code, test, and docs and commit/rebase again. |
|
|
Every time a new connection is made to a sockjs server, a session id is generated in the client and sent to the server. This session id helps the server distinguish connections. By default, the current code generates a random 8-character-long string as session id. There is currently no way to increase the entropy or even generate your own session ids, so this commit is an attempt to tackle that limitation by specifying the option called sessionId in the options passed to SockJS.
imkira
force-pushed
the
allowCustomSessionIds
branch
from
4f677b9 to
e668284
Compare
|
@brycekahle how does it look now |
|
Looks great! |
|
Thanks a lot |
|
By the way sorry, I don't know much about the release cycle of sockjs-client. Can you tell me when is the next release that includes this commit? Thanks |
|
I can try and get a new version out this week. |
|
Looking forward to! |
|
@imkira I just released 1.0.1 |
|
@brycekahle thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a new connection is made to a sockjs server, a session id is
generated in the client and sent to the server. This session id helps
the server distinguish connections. By default, the current code
generates a random 8-character-long string as session id. There is
currently no way to increase the entropy or even generate your own
session ids, so this commit is an attempt to tackle that limitation.