Fail in Connection#write_frames if @framer is nil.

socketry · Apr 20, 2024 · f80180b · f80180b
1 parent 74b262e
commit f80180b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/protocol/http2/connection.rb b/lib/protocol/http2/connection.rb
@@ -211,7 +211,11 @@ def write_frame(frame)
 			end
 
 			def write_frames
-				yield @framer
+				if @framer
+					yield @framer
+				else
+					raise EOFError, "Connection closed!"
+				end
 			end
 
 			def update_local_settings(changes)

diff --git a/test/protocol/http2/connection.rb b/test/protocol/http2/connection.rb
@@ -65,6 +65,15 @@
 			connection.read_frame
 		end.to raise_exception(Protocol::HPACK::Error)
 	end
+
+	it "can't write frames to a closed connection" do
+		connection.close
+
+		expect do
+			connection.write_frames do |framer|
+			end
+		end.to raise_exception(EOFError, message: be =~ /Connection closed/)
+	end
 end
 
 with 'client and server' do