Better handling of bare Async
and Sync
blocks when a scheduler is defined.
#340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested fibers can cause issues with Async, when spawning child tasks within them. I was affected by this issue when trying to create a streaming response from a Rails controller, using the
proc do |stream| ... Async{....} end
style response body. However,protocol-rack
uses a normal fiber to wrap streaming responses and the child Async task has no parent, causing it to try and create a new event loop... meltdown ensues.Ideally,
Async
andSync
helpers should work when anyFiber.scheduler
is defined. Right now, it's unrealistic to expectAsync::Task
to work in any scheduler, but at the very least, the following should work:In order to do this, bare
Async
andSync
blocks should useFiber.scheduler
as a parent if possible.Types of Changes
Contribution