Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to system nameservers if a Resolver is initialized without any. #30

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

seandilda
Copy link
Contributor

This change allows Resolver to be created without specifying nameservers. When no nameservers are specified, the system resolver config is used.

Types of Changes

  • Quality of Life Improvement

Contribution

@ioquatix ioquatix merged commit 99ffdd5 into socketry:main Jul 12, 2024
6 of 9 checks passed
@ioquatix
Copy link
Member

Thanks, this is a reasonable change and a nice improvement.

@ioquatix
Copy link
Member

I have been trying out this change, and I found the (my) implementation lacking.

Specifically, just using the system nameservers is insufficient, as there are other options like search domains, and so on, that are required. I've added Async::DNS::System.resolver which is also exposed by Async::DNS::Resolver.default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants