Improved header edge cases #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he server. Added some handling.
|
Looks good! Thanks |
darrachequesne
added a commit
that referenced
this pull request
Jul 4, 2024
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
Fix iojs 3.0 Buffer.buffer issue
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
The second WebSocket created after an upgrade should gracefully close and not throw an error as specified the official implementation.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to pass an origin causes the server to throw an exception and effectively crash. I added a little code to handle this case.