Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with node-redis v4.0.0 #417

Closed
xairoo opened this issue Sep 10, 2021 · 3 comments
Closed

Doesn't work with node-redis v4.0.0 #417

xairoo opened this issue Sep 10, 2021 · 3 comments
Milestone

Comments

@xairoo
Copy link

xairoo commented Sep 10, 2021

I updated node-redis from v3.1.2 to 4.0.0 on my node client and socket.io stopped working. First emit is send, then it crashes.

Node client:

Error: Got an unexpected reply from Redis
    at RedisCommandsQueue._RedisCommandsQueue_shiftWaitingForReply

Socket.io server (redis 3.1.2):

node_modules\notepack.io\lib\decode.js:246
    throw new Error((buffer.length - decoder.offset) + ' trailing bytes');

Running Socket.io server with redis 4.0.0:

node_modules\@socket.io\redis-adapter\dist\index.js:64
        this.subClient.psubscribe(this.channel + "*", onError);
                       ^

TypeError: this.subClient.psubscribe is not a function
    at new RedisAdapter
@kor3k
Copy link

kor3k commented Oct 7, 2021

node-redis got the command method names changed in v4. it's all uppercase now.

@darrachequesne
Copy link
Member

Please see #423 (comment)

@darrachequesne
Copy link
Member

Support for redis@4 was added in release 7.1.0: https://github.com/socketio/socket.io-redis-adapter/releases/tag/7.1.0

@darrachequesne darrachequesne added this to the 7.1.0 milestone Nov 30, 2021
@darrachequesne darrachequesne unpinned this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants