Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document connected and disconnected socket properties #1155

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Document connected and disconnected socket properties #1155

merged 2 commits into from
Feb 28, 2018

Conversation

perrin4869
Copy link
Contributor

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Documents the previously undocumented connected and disconnected properties of a Socket object.

https://github.com/socketio/socket.io-client/blob/master/lib/socket.js#L63
https://github.com/socketio/socket.io-client/blob/master/lib/socket.js#L64

@darrachequesne darrachequesne merged commit bb743c4 into socketio:master Feb 28, 2018
@darrachequesne
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perrin4869 @darrachequesne