New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix never running timingOut due to weak self capture #1463

Merged

nuclearace merged 1 commit into socketio:development from davidkessler-ch:master

Nov 13, 2023

Contributor

davidkessler-ch commented Nov 10, 2023 •

edited

Loading

Refer to: this issue

Fixed [the timeOut callback function never running] by removing the weak self capture in the timingOut function. Not sure why self is lost in the first place, but retain cycles are not a problem since they are only temporary anyways with asyncAfter(...) { }


          fix never running timingOut due to weak self capture

a21af10

nuclearace changed the base branch from master to development

November 13, 2023 20:34

nuclearace merged commit 76b9419 into socketio:development

1 check passed

mendimr commented Jul 12, 2024

@nuclearace Any news when this PR will be merged with main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet