Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection error handling if the connection state is wrong #1233

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Fix connection error handling if the connection state is wrong #1233

wants to merge 3 commits into from

Conversation

allenlinli
Copy link

  • fix: handle failure in connect
  • feat: add test testConnectedAlready

@nuclearace
Copy link
Member

@allenlinli Looks like that test failed

@allenlinli
Copy link
Author

I see, I'll fix it in the next week.

@allenlinli allenlinli force-pushed the debug/connectErrorHandling branch 2 times, most recently from 69b0062 to 76a96ad Compare December 30, 2019 07:43
@allenlinli allenlinli closed this Dec 30, 2019
@allenlinli allenlinli deleted the debug/connectErrorHandling branch December 30, 2019 07:44
@allenlinli allenlinli restored the debug/connectErrorHandling branch December 30, 2019 07:44
@allenlinli
Copy link
Author

allenlinli commented Dec 30, 2019 •
edited
Loading

Sorry for the late update. Here is the fix.

@allenlinli allenlinli reopened this Dec 30, 2019
@allenlinli allenlinli force-pushed the debug/connectErrorHandling branch from 76a96ad to 20c7421 Compare January 2, 2020 09:02
@allenlinli allenlinli force-pushed the debug/connectErrorHandling branch from 20c7421 to f2c892b Compare January 3, 2020 04:19
@Perronef5
Copy link

Hi can we merge this into develop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allenlinli @nuclearace @Perronef5