Eslint #385
Closed
Eslint #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change var to const in gulpfile - indentation fix
- Add dependencies - Add root eslintrc - Add gulp lint task
| this.verify(req, true, function(err, success) { | ||
| if (!success) { | ||
| this.verify(req, true, function (err, success) { | ||
| if (err) { |
There was a problem hiding this comment.
ESLint requires us to make use of err when handling the error callback. Should I make an exception to the rule here, or is the way I handle it currently is fine? It passes the test now.
To note: - check err instead of !success in lib/server.js:321 - Change while loop with assignment to for loop
| var path = (options.path || '/engine.io').replace(/\/$/, ''); | ||
|
|
||
| var destroyUpgrade = (options.destroyUpgrade !== undefined) ? options.destroyUpgrade : true; | ||
| var destroyUpgradeTimeout = options.destroyUpgradeTimeout || 1000; |
There was a problem hiding this comment.
This is the diff comment that requires attention
This variable destroyUpgradeTimeout is not actually used, but it seems as if it should be used, looking at line 450.
|
@digawp how about using something like https://github.com/Flet/semistandard? Won't it be easier to maintain? |
|
Thanks a lot for the hard work, btw! |
darrachequesne
pushed a commit
that referenced
this pull request
Oct 31, 2016
|
Merged as 7cbdd5e. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief:
gulp lint)Important changes/refactoring due to ESLint will be annotated on the diff.
There is a lint error I purposely left out because I would like to check with the core team regarding that. I will comment on the diff itself