-
Notifications
You must be signed in to change notification settings - Fork 565

Description
- report a bug
- request a feature
Current behaviour
For Nodejs 8.x and 9.x (with uws = 8.x) works properly.
For Nodejs 10.x + uws (>= 8.x <= 9.x): it throws an error saying "Error: Compilation of µWebSockets has failed and there is no pre-compiled binary available for your system. Please install a supported C++11 compiler and reinstall the module 'uws'".
For Nodejs 10.x + uws (>=10.x):cannot find module 'uws'.
Steps to reproduce (if the current behaviour is a bug)
Just assign 'uws' to wsEngine
, each time I'll remove all the imports by directly removing node_modules and install them by running npm i
. Then my uws
is installed in the mode of dev-dependencies.
Expected behaviour
Works properly like Node 8 or 9.
Setup
- OS: Windows 8.1 (SP1), Linux (x64
- browser: N/A
- socket.io version: 2.0.4
Other Info
I found uws
is deprecated now, so in the main page of Socket.IO SHOULD'T SUPPORT THAT any more (See https://socket.io/docs/server-api/ part). And maybe there's something code to be changed with, or change to a new lib something like uws
.
See the DUPLICATED uws
: https://www.npmjs.com/package/uws, the version is changing TOO RAPIDLY, not so stable.
Maybe the logic as well as socketio should be modified?
(See codes at:
Line 107 in 6a16ea1
case 'uws': wsModule = require('uws'); break; |