Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPack is broken due to the wsEngine option #522

Closed
markbjerke opened this issue Jul 29, 2017 · 0 comments
Closed

WebPack is broken due to the wsEngine option #522

markbjerke opened this issue Jul 29, 2017 · 0 comments

Comments

@markbjerke
Copy link
Contributor

We can mitigate the WebPack issue by testing for the option being defined in a if/else branch, that way if the option is not defined there can be a require with a static path. As known there can be no variables in the require statement in order for WebPack to static resolve the asset.

This would allow those who are happy with the default ( most people ? ) to bundle the code for node targets with WebPack. It would still break bundling for users who did exercise the option for a different Websocket package, but I'm just guessing that the number is small and even smaller who want to bundle.

It's a trivial change to sniff the option in a branch first.

@markbjerke markbjerke changed the title WebPackis broken due to the wsEngine option WebPack is broken due to the wsEngine option Jul 29, 2017
darrachequesne added a commit that referenced this issue May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant