-
Notifications
You must be signed in to change notification settings - Fork 571
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[chore] Revert to
ws
as default wsEngine (#550)
Related: - socketio/socket.io#2956 - socketio/socket.io#3100 Fixes #536 Fixes #516 Fixes #474
- Loading branch information
1 parent
d50bf87
commit b1fa020
Showing
3 changed files
with
8 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,14 +45,12 @@ | |
"expect.js": "^0.3.1", | ||
"mocha": "^4.0.1", | ||
"s": "0.1.1", | ||
"superagent": "^3.8.1" | ||
}, | ||
"optionalDependencies": { | ||
"superagent": "^3.8.1", | ||
"uws": "~9.14.0" | ||
}, | ||
"scripts": { | ||
"lint": "eslint lib/ test/ *.js", | ||
"test": "npm run lint && mocha && EIO_WS_ENGINE=ws mocha" | ||
"test": "npm run lint && mocha && EIO_WS_ENGINE=uws mocha" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
darrachequesne
Author
Member
|
||
}, | ||
"repository": { | ||
"type": "git", | ||
|
If 'ws' was set back as default engine, why tests are run against 'uws'?