Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLHTTPRequest module is fetched from github rather then NPM #405

Closed
stefanpenner opened this issue Jul 17, 2015 · 35 comments
Closed

XMLHTTPRequest module is fetched from github rather then NPM #405

stefanpenner opened this issue Jul 17, 2015 · 35 comments

Comments

@stefanpenner
Copy link

https://github.com/socketio/engine.io-client/blob/master/package.json#L38

For users without access to github (those with internal private NPM mirrors, but not github access) this causes some grief.

A related issue: ember-cli/ember-cli#4328

Is it possible for us to get a release, where XMLHTTPRequest is either:

  • added as a bundleDependency – so users will just get it as part of the engine.io-client tarbal from npm
  • published as npm module
@jeffshaver
Copy link

👍

stefanpenner added a commit to ember-cli/ember-cli that referenced this issue Jul 17, 2015
stefanpenner added a commit to ember-cli/ember-cli that referenced this issue Jul 17, 2015
…hen bundle the one it wanted in ember-cli’s tarball

pending: socketio/engine.io-client#405
stefanpenner added a commit to ember-cli/ember-cli that referenced this issue Jul 17, 2015
…hen bundle the one it wanted in ember-cli’s tarball

pending: socketio/engine.io-client#405
@bushong1
Copy link

Dupe of #348

@jskrzypek
Copy link
Contributor

And #358, and #384, and #402 😄

stefanpenner added a commit to ember-cli/ember-cli that referenced this issue Jul 20, 2015
…hen bundle the one it wanted in ember-cli’s tarball

pending: socketio/engine.io-client#405
stefanpenner added a commit to ember-cli/ember-cli that referenced this issue Jul 20, 2015
stefanpenner added a commit to ember-cli/ember-cli that referenced this issue Jul 21, 2015
…hen bundle the one it wanted in ember-cli’s tarball

pending: socketio/engine.io-client#405
@benjamind
Copy link

Please fix this, its causing major headaches.

@jeffshaver
Copy link

@stefanpenner yeah this is still not working correctly. even the new version tries to fetch from github.

@uglow
Copy link

uglow commented Aug 17, 2015

👍 We really need this

@ichyr
Copy link

ichyr commented Aug 18, 2015

Really an issue! Please fix this!

Eventually there is https://www.npmjs.com/package/xmlhttprequest such module, so this change can be very easy.

@uglow
Copy link

uglow commented Aug 20, 2015

FWIW, we upgraded Node from version 0.11.something to version 0.12.7. When NPM (the one bundled with Node 0.12.7) is resolving dependencies and sees "xmlhttprequest": "https://github.com/rase-/node-XMLHttpRequest/archive/a6b6f2.tar.gz", it NOW uses NPM's HTTPS_PROXY setting to request the file. Version 11.x was not using NPM's HTTPS_PROXY setting.

TL;DR: Try upgrading to Node 0.12.7.

Thanks to @irgeek for working through this.

@jeffshaver
Copy link

@uglow Sadly, this isn't an option for us. The environment that I am in is fairly restrictive and there isn't an easy upgrade path.

@smooney
Copy link

smooney commented Aug 25, 2015

Adding another name to this request. Definitely a headache and unusable in our private npm repo.

@ichyr has the correct solution IMO.

@ScottWeinstein
Copy link

Looks like this is fixed, and just needs to be pushed to npm

@richardbutler
Copy link

+1,000,000

Anyone stuck behind a proxy is stuck with socket.io@0.9.x, no webpack-dev-server, etc, etc. This has knock-on effects. Please publish this to NPM and then bump socket.io to 1.3.8 to point to engine.io-client@1.5.5, this will pull the rod out from so many arses. Thanks!

@bushong1
Copy link

@richardbutler well said.

@UnrememberMe
Copy link

yes, please. Add another vote here.

@nkbt
Copy link

nkbt commented Sep 25, 2015

Oh, here is the actual reason why builds are failing...

@mdasberg
Copy link

+1

@Den-dp
Copy link

Den-dp commented Oct 7, 2015

Looks like the appropriate fixes are already present in the master branch e700bd2
Can we npm publish, please?

@samu
Copy link

samu commented Oct 9, 2015

+1

2 similar comments
@tsing80
Copy link

tsing80 commented Oct 13, 2015

+1

@lironess
Copy link

+1

@sbley
Copy link

sbley commented Oct 14, 2015

+1
Please publish to npm. It has been fixed for a couple of months now.

@cristisp
Copy link

+1
Please publish this fixed version to npm as soon as possible. It's causing a lot of problems for people who cannot access GitHub directly.

@bushong1
Copy link

I can't believe this is still an issue for something merged on August 29th. Very frustrating.

@jeffshaver
Copy link

I just pinged @rauchg on slack to try and get this done

@bushong1
Copy link

@jeffshaver i'm guessing no luck on this front?

@jeffshaver
Copy link

@bushong1 yeah. no response. and it looks like their slack is down right now so I can't hop back in to check in.

@estekhin
Copy link

estekhin commented Nov 2, 2015

Please publish the new version with the fix to npm.

@igogrek
Copy link

igogrek commented Nov 2, 2015

+1 waiting for an npm publish.

@danielepolencic
Copy link

+1

@eladh
Copy link

eladh commented Nov 19, 2015

hi @rauchg :-)
Is there anything we can do to finish the npm publish process ?

thanks in advance,
elad.

@jreading
Copy link

has-cors github dep was also fixed. 🕐 time to publish

@prndP
Copy link

prndP commented Dec 4, 2015

+1

1 similar comment
@julianvmodesto
Copy link

+1

@richardbutler
Copy link

Looks like this one is now fixed. 👍

@nkzawa
Copy link
Contributor

nkzawa commented Jan 16, 2016

yep, fixed. Thanks!!!

@nkzawa nkzawa closed this as completed Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests