Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Config option hub.forkrepo was ignored #157

Closed
wants to merge 1 commit into from

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Oct 23, 2015

In the whole file, the string forkrepo only appears in the config class..

@leandro-lucarella-sociomantic
Copy link
Contributor

Interesting. I wonder why this was allowed to be overridden, as normally it should be <user>/<repo>. Maybe to work in some weird setup where you have this workflow but not in your private repo. In this case I wonder if we should have an option for git hub clone too to use a different forkrepo (and probably set the variable)?

Do you have a usercase for this or you detected it just by chance?

@Marenz
Copy link
Contributor Author

Marenz commented Oct 23, 2015

My workflow is that I only use the same repo for the source & target branch. That's when I found this problem

@leandro-lucarella-sociomantic
Copy link
Contributor

My workflow is that I only use the same repo for the source & target branch. That's when I found this problem

Ah, OK, I wonder if it would be nice to add a command line option to override this...

@leandro-lucarella-sociomantic
Copy link
Contributor

This pull request has been rebased via git hub pull rebase. Original pull request HEAD was ca51d56, new (rebased) HEAD is a1219e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants