Allow cloning over https instead of ssh

[llucax]

If I try git hub clone https://github.com/author/repo then git-hub unhelpfully changes that to git@github.com:author/repo. The entire reason I used an https URL is because I want to use it instead of ssh. In fact, I have to because ssh is blocked in this environment.

[llucax]

Labeled as both enhancement and bug because supporting URLs for git hub clone was a hack in the first place, it was never supposed to add support for https. So is an enhancement in that sense, but from the user perspective is clearly a bug.

It's probably not too hard to fix though.

[jwilk]

As a data point, I like the current behavior.
If I run git hub clone https://github.com/foo/bar, it's because the full URL is the easiest thing to copy&paste, not because I enjoy HTTPS.
Please keep an option to always clone over SSH, regardless of what the URL says.

[jamessan]

I'd be fine with a git-config option to indicate I want to use https. That should satisfy both Jakub's use case and mine.

[llucax]

James McCoy, el 17 de September a las 04:38 me escribiste:

I'd be fine with a git-config option to indicate I want to use https.
That should satisfy both Jakub's use case and mine.

Haha, but I think that's terribly counter-intuitive. Really, you type
clone https://... and get a SSH based clone, or vice-versa?

For me that's the worse case scenario... I would be willing to make it
like clone --force-ssh https://..., but then all the convenience of
copy&paste is gone, I guess.

I think is reasonable to ask the user to do one more click to copy the
SSH URL instead of the HTTPS one for the sake of an intuitive CLI.

[llucax]

Relabeling as bug-only, as other types of URLs are supported via the config option hub.urltype. Also removing the difficutly-easy tag as it wasn't so easy 😁

[llucax]

Fix attached.

@gkotian sorry for kind of destroying what you did in #160. 👼

@andrej-mitrovic-sociomantic I made this PR using my master branch so I can test #136 fix 💃

@jwilk I didn't include a way to force a URL type in this PR, I consider that a different issue (an enhancement). I'd be OK to add something like --force-urltype to the clone command (which can use the current hub.urltype if no option is used or could accept an arbitrary URL type). I don't think I'll fix this myself though, because I think is a bit too niche and not generally useful.

[llucax]

BTW, also UNTESTED. Help testing this is very much appreciated.

[llucax]

I'd like to test at least:

• clone repo
• clone owner/repo
• clone user/repo (the same as clone repo but explicitly setting the owner to the current user to test Error on trivially incorrect usage of clone command #160)
• clone https://github.com/owner/repo.git (HTTP)
• clone https://github.com/owner/repo (SVN, should be ignored with a warning)
• clone git@github.com:/owner/repo.git (SSH)
• clone git:github.com/owner/repo.git (git, I'm not sure it will work, is only in the API)
• Any random piece of garbage you can think of to see if the error messages make sense (or how badly it crashes :D)

[jwilk]

Typo: the current the config → the current config

I would have never thought that https://github.com/owner/repo has anything to do with SVN. It works with git clone just fine. In fact, that's the exact URL format that @jamessan wanted to use with git hub clone.

I'm getting 404 when trying to clone my own repos, regardless of URL type:

$ git hub -v clone didjvu
git command: ['git', 'config', 'hub.username'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.oauthtoken'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.upstream'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.forkrepo'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.forkremote'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.pullbase'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.urltype'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.baseurl'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', '--bool', 'hub.forcerebase'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', '--bool', 'hub.triangular'] {'stderr': -1, 'stdout': -1}
git command: ['git', 'config', 'hub.password'] {'stderr': -1, 'stdout': -1}
Request: GET https://api.github.com/repos/jwilk/jwilk/didjvu?
None
https://api.github.com/repos/jwilk/jwilk/didjvu?
Content-length: 0
Content-type: application/json
Authorization: <hidden>
Accept: application/vnd.github.v3+json
None
Error: GitHub error: Not Found
HTTP Error 404: Not Found
https://api.github.com/repos/jwilk/jwilk/didjvu?
<httplib.HTTPMessage instance at 0xf6c4620c>

I don't see any point in command-line option for forcing URL type.
OTOH configuration option for forcing URL type would be useful; but it's not a big deal, I can live without it.

[llucax]

Arrrgh! Hopefully fixed. Thanks for the testing!

About SVN, OK, then I can simplify even further the heuristics to select the correct url type. Much better (and no mention to SVN in a git subcommand :D).

diff --git a/git-hub b/git-hub
index dc7a19d..464c7be 100755
--- a/git-hub
+++ b/git-hub
@@ -792,18 +792,12 @@ class CloneCmd (object):
                urltype = config.urltype
                if repo.endswith('.git'):
                        repo = repo[:-4] # remove suffix
-                       if repo.startswith('https://'):
-                               urltype = 'clone_url' # how GitHub calls HTTP
-                       elif repo.startswith('git:'):
-                               urltype = 'git_url'
-                       elif ':' in repo:
-                               urltype = 'ssh_url'
-               elif repo.startswith('https://'): # and it doesn't end with .git
-                       warnf("{} looks like a SVN URL, which doesn't make a "
-                                       "lot of sense to use with git, we'll "
-                                       "use the current the config option "
-                                       "hub.urltype ({}) instead.",
-                                       repo, urltype)
+               if repo.startswith('https://'):
+                       urltype = 'clone_url' # how GitHub calls HTTP
+               elif repo.startswith('git:'):
+                       urltype = 'git_url'
+               elif ':' in repo:
+                       urltype = 'ssh_url'
                # At this point we need to have an urltype
                if urltype is None:
                        die("Can't infer a urltype and can't find the config "
@@ -821,7 +815,7 @@ class CloneCmd (object):
        def setup_repo(cls, proj):
                # Own repo
                if proj.split('/')[0] == config.username:
-                       repo = req.get('/repos/%s/%s' % (config.username, proj))
+                       repo = req.get('/repos/' + proj)
                        if repo['fork']:
                                upstream = repo['parent']['full_name']
                        else:

[leandro-lucarella-sociomantic]

Some basic testing for own repos seems to work fine.

[jwilk]

Now it looks good to me.

[llucax]

Merge, please? Maybe?

[gautam-kotian-sociomantic]

LGTM.

[leandro-lucarella-sociomantic]

OK, auto-merging as it seems like @mihails-strasuns-sociomantic is taking a nap 😝

[leandro-lucarella-sociomantic]

This pull request has been rebased via git hub pull rebase. Original pull request HEAD was 4cc377d, new (rebased) HEAD is a392421

[leandro-lucarella-sociomantic]

BTW, I rebased this using #136 and it worked fine.