Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in error message #162

Closed
andrej-mitrovic-sociomantic opened this issue Nov 11, 2015 · 4 comments
Closed

Typo in error message #162

andrej-mitrovic-sociomantic opened this issue Nov 11, 2015 · 4 comments

Comments

@andrej-mitrovic-sociomantic
Error: Can't start a pull rebase while a regular reabase is in progress

reabase => rebase.

Also it would be nice if it said we can use git rebase --abort in this case.

@llucax
Copy link
Member

llucax commented Nov 11, 2015

No PR? 😊

And about the git rebase --abort suggestion, I'm not sure the tool should do that, that's only true if you want to abort the current rebase, but there might be many cases where you don't (you want to finish it). I'm not very sure about giving advice in the tool to do something that can potentially make the user lose work. And explaining all this might be too much for an error message, it is expected that the user knows how to use git.

@andrej-mitrovic-sociomantic
Copy link
Author

PR coming tomorrow!

On Wed, Nov 11, 2015 at 2:07 PM -0800, "Leandro Lucarella" <notifications@github.commailto:notifications@github.com> wrote:

No PR? [:blush:]

And about the git rebase --abort suggestion, I'm not sure the tool should do that, that's only true if you want to abort the current rebase, but there might be many cases where you don't (you want to finish it). I'm not very sure about giving advice in the tool to do something that can potentially make the user lose work. And explaining all this might be too much for an error message, it is expected that the user knows how to use git.

Reply to this email directly or view it on GitHubhttps://github.com//issues/162#issuecomment-155924685.

@andrej-mitrovic-sociomantic
Copy link
Author

This appears to be fixed.

@leandro-lucarella-sociomantic
Copy link
Contributor

Thank @jwilk (bed0473).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants