-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Range): Assert that number of columns is an integer #33
Conversation
Happy to review. |
I am now facing this error from the tests:
Don't think I can fix that x) |
What is the status of this PR? Should we keep it or close it? As it is now, it can not be merged as the tests are not working. |
Hi @philippe2803, gonna take a look to the semantic release issue and fix the tests asap. |
I originally thought the tests actually failed, but it's only a problem with the semantic release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Feel free to merge without my input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this branch for about a month now without problems. Let's get it merged!
When i try the following methods:
sheet.get_range_from_a1("D2:FG2").get_values()
, sheetfu throws the following error:for column in range(0, self.coordinates.number_of_columns): TypeError: 'float' object cannot be interpreted as an integer
Checked further and it seems that in this case, with this range specified, the self.coordinates.number_of_columns variable contains the number '160.0'.