Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Range): Assert that number of columns is an integer #33

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

luchinke
Copy link

@luchinke luchinke commented Dec 5, 2019

When i try the following methods: sheet.get_range_from_a1("D2:FG2").get_values(), sheetfu throws the following error:
for column in range(0, self.coordinates.number_of_columns): TypeError: 'float' object cannot be interpreted as an integer

Checked further and it seems that in this case, with this range specified, the self.coordinates.number_of_columns variable contains the number '160.0'.

@philippe2803
Copy link
Contributor

Happy to review.
Could you please make the tests pass before I check?

@luchinke
Copy link
Author

luchinke commented Dec 5, 2019

I am now facing this error from the tests:

The verification check for the environment did not pass. The command "if [ "$BRANCH" == "master" ]; then semantic-release publish; fi" exited with 1.

Don't think I can fix that x)

@philippe2803
Copy link
Contributor

@luchinke
@sp-daniel-sanchez

What is the status of this PR? Should we keep it or close it? As it is now, it can not be merged as the tests are not working.

@sp-daniel-sanchez
Copy link
Contributor

Hi @philippe2803, gonna take a look to the semantic release issue and fix the tests asap.

@philippe2803
Copy link
Contributor

philippe2803 commented Jan 31, 2020

I originally thought the tests actually failed, but it's only a problem with the semantic release.
Happy to merge as soon as the semantic release issue is fixed. Can someone look into it?

@SP-alex-muelas
Copy link
Contributor

It was a bug in the semantic release script, it was not checking if the PR was coming from a fork. I've fixed it in this PR #39.
@luchinke can you close and re-open this PR for the travis job to run again?

@luchinke luchinke closed this Feb 24, 2020
@luchinke luchinke reopened this Feb 24, 2020
Copy link
Contributor

@philippe2803 philippe2803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@philippe2803
Copy link
Contributor

Feel free to merge without my input.

Copy link

@jlasky jlasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this branch for about a month now without problems. Let's get it merged!

@philippe2803 philippe2803 merged commit a1b9bb5 into socialpoint-labs:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants