[mobile feature]: single main.dart, app flavor from environment, less duplicated code #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KarinBerg
commented
Jul 21, 2024
ssandino
approved these changes
Aug 4, 2024
ssandino
changed the title
|
Visit the preview URL for this PR (updated for commit dc92f53): https://si-admin-staging--pr870-karin-refactor-main-52vu8rda.web.app (expires Sat, 05 Oct 2024 12:57:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had three main_*.dart files which contains almost the same code. So I refactored it to one again and read the app flavor from the environment.
TODO after merge: Adjust .vscode/launch.json