feature(website): overview section on new landing page #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkMenacer
requested review from
andrashee,
mkue,
ssandino and
socialincome-dev
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mkue
approved these changes
Jul 21, 2024
website/src/app/[lang]/[region]/v2/(home)/(sections)/overview.tsx
Outdated
Show resolved
Hide resolved
| // <BaseContainer backgroundColor="bg-foreground-dark" className="py-3"> | ||
| <BaseContainer className="theme-blue-v2 py-3"> | ||
| {' '} | ||
| {/* Is there a way to use theme-blue-v2 to set background blue? */} |
There was a problem hiding this comment.
This comment is not needed anymore, right? You are setting the theme now...
There was a problem hiding this comment.
This wasn't working as expected on my local system or on the deployed one either, is it on yours?
Ideally it should be screen-wide but that is not happening for some reason
|
Visit the preview URL for this PR (updated for commit b27cb39): https://si-admin-staging--pr864-pranav-new-landing-o-tlsp9fzi.web.app (expires Sat, 17 Aug 2024 12:02:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
…o pranav/new-landing-overview
mkue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.