Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(website) refactor: Footer Migration #568

Merged
merged 11 commits into from
Sep 20, 2023
Merged

(website) refactor: Footer Migration #568

merged 11 commits into from
Sep 20, 2023

Conversation

anthonyray
Copy link
Contributor

@anthonyray anthonyray commented Sep 15, 2023 •
edited
Loading

Hi there 👋🏾 !

  • This PR introduces two new components : Footer (server-side component), FooterClient (client-side component). These components are added to the default layout of the website to create the footer section.
  • This PR refactors some language switching logic happening in the navbar component to share it with the footer components.

I still need some help before moving from draft to final P.R :

  • Code Formatting + Linting
  • Footer items translations
    -> I'll open up another P.R for the translations.
  • Combobox display bug for small viewports
  • Icons validation
    I'm using icons from heroicons, and they don't match the previous icons (cf screenshot)

@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 1:08pm

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://socialincome-san.github.io/public/functions-playwright-report/pr-568/
on branch gh-pages at 2023-09-20 13:07 UTC

@anthonyray anthonyray mentioned this pull request Sep 15, 2023
Closed
4 tasks
@mkue
Merge branch 'main' into website-footer-migration
39597e3 
# Conflicts:
#	ui/src/index.ts
#	website/src/app/[lang]/[country]/(website)/layout.tsx
#	website/src/components/navbar/language-switcher.tsx
#	website/src/components/navbar/navbar.tsx
@mkue
use shadcn select component and slightly update styling
21e007a
@mkue mkue marked this pull request as ready for review September 20, 2023 13:04
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 21e007a):

https://si-admin-staging--pr568-website-footer-migra-1x6nt325.web.app

(expires Wed, 27 Sep 2023 13:09:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

mkue
mkue approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@mkue mkue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @anthonyray 🎉😊

I dared to update your code directly here (and will merge this PR). I made quite many changes in the ui project – I decided to switch from DaisyUI to shadcn – which caused some merge conflicts here that I thought would be a pain for you to resolve.

Feel free to look at the changes in my last commit and make adjustments in a new PR. The translations are still static, so that still needs to be done (but isn't urgent).

@mkue mkue merged commit ab6c420 into main Sep 20, 2023
22 checks passed
@mkue mkue deleted the website-footer-migration branch September 20, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkue mkue mkue approved these changes

@andrashee andrashee Awaiting requested review from andrashee andrashee is a code owner

@ssandino ssandino Awaiting requested review from ssandino ssandino is a code owner

@renestalder renestalder Awaiting requested review from renestalder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyray @mkue